Skip to content

Space after comma in array#268

Closed
kkmuffme wants to merge 1 commit into
phpDocumentor:2.xfrom
kkmuffme:array-space-after-key-comma
Closed

Space after comma in array#268
kkmuffme wants to merge 1 commit into
phpDocumentor:2.xfrom
kkmuffme:array-space-after-key-comma

Conversation

@kkmuffme

@kkmuffme kkmuffme commented Dec 7, 2025

Copy link
Copy Markdown

Is the more common syntax (psalm, phpstan, WP) and also already used in e.g. ArrayShape.php

Is the more common syntax (psalm, phpstan, WP) and also already used in e.g. ArrayShape.php

@mspirkov mspirkov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mspirkov

mspirkov commented Dec 7, 2025

Copy link
Copy Markdown
Contributor

You should fix the tests.

@jaapio

jaapio commented Dec 8, 2025

Copy link
Copy Markdown
Member

Please have a look at the failing tests.

@mspirkov

Copy link
Copy Markdown
Contributor

Fixed it everywhere: #273

@jaapio

jaapio commented Dec 13, 2025

Copy link
Copy Markdown
Member

Closing because the follow up PR has been merged. Thanks for your suggestion to improve this.

@jaapio jaapio closed this Dec 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants